Re: [PATCH] rust: locks: Add `get_mut` method to `Lock`

[Martin Rodriguez Reboredo]

On 2/9/24 13:22, Mathys-Gasnier wrote:
> From: Mathys-Gasnier <mathys35.gasnier@xxxxxxxxx>
>
> Having a mutable reference guarantees that no other threads have
> access to the lock, so we can take advantage of that to grant callers
> access to the protected data without the the cost of acquiring and
> releasing the locks. Since the lifetime of the data is tied to the
> mutable reference, the borrow checker guarantees that the usage is safe.
>
> Signed-off-by: Mathys-Gasnier <mathys35.gasnier@xxxxxxxxx>
> ---
> [...]
> +    /// Gets the data contained in the lock

I wish that this doc comment mentioned what you've said about having a
mutable reference avoids locking, much like the documentation on
`std::sync::Mutex::get_mut`. If you do so then you can add my reviewed.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>

> +    pub fn get_mut(&mut self) -> &mut T {
> +        self.data.get_mut()
> +    }
>   }
> [...]