Re: dm vdo slab-depot: delete unnecessary check

From: Markus Elfring
Date: Sun Feb 11 2024 - 13:30:15 EST

Next message: Subbaraya Sundeep: "[PATCH 1/2] octeontx2-af: Remove the PF_FUNC validation for NPC transmit rules"
Previous message: Yinchuan Guo: "[PATCH] Subject: [PATCH] sound: drivers: fix typo 'reguest' to 'request'"
In reply to: Dan Carpenter: "[PATCH] dm vdo slab-depot: delete unnecessary check"
Next in thread: Mike Snitzer: "Re: dm vdo slab-depot: delete unnecessary check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> This is a duplicate check

Was this implementation detail detected with any known source code analysis tool?

> so it can't be true. …

I suggest to reconsider this information a bit more.
Would you usually expect the outcome “result == VDO_SUCCESS” from a call
of the function “uds_allocate”?

Regards,
Markus

Next message: Subbaraya Sundeep: "[PATCH 1/2] octeontx2-af: Remove the PF_FUNC validation for NPC transmit rules"
Previous message: Yinchuan Guo: "[PATCH] Subject: [PATCH] sound: drivers: fix typo 'reguest' to 'request'"
In reply to: Dan Carpenter: "[PATCH] dm vdo slab-depot: delete unnecessary check"
Next in thread: Mike Snitzer: "Re: dm vdo slab-depot: delete unnecessary check"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]