Re: [PATCH net-next 1/3] net: phy: Add support for inband extensions

From: Maxime Chevallier
Date: Tue Feb 13 2024 - 04:08:28 EST


Hello Jakub,

On Mon, 12 Feb 2024 17:25:11 -0800
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Mon, 12 Feb 2024 18:33:04 +0100 Maxime Chevallier wrote:
> > +/**
> > + * PHY modes in the USXGMII family can have extensions, with data transmitted
> > + * in the frame preamble.
> > + * For now, only QUSGMII is supported, but other variants like USGMII and
> > + * OUSGMII can be added in the future.
> > + */
> > +static inline bool phy_interface_has_inband_ext(phy_interface_t interface)
>
>
> Spurious use of /**, it seems. You either need to use full kdoc format,
> or the normal /* comment start.

Ah sorry about that, I'll address it. Thanks for taking a look !

Maxime