Re: [PATCH v2] misc: eeprom/idt_89hpesx: Convert data structures to LE explicitly
From: Arnd Bergmann
Date: Wed Feb 14 2024 - 05:17:37 EST
On Wed, Jan 31, 2024, at 04:30, Dawei Li wrote:
> Kernel test robot reports following sparse warnings:
>>> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse: sparse:
> incorrect type in assignment (different base types) @@
> expected unsigned short [addressable] [assigned] [usertype]
> memaddr @@ got restricted __le16 [usertype] @@
>
> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
> expected unsigned short [addressable] [assigned] [usertype]
> memaddr
>
> drivers/misc/eeprom/idt_89hpesx.c:599:31: sparse:
> restricted __le16 [usertype]
>
> .....
>
> For data structures needs cpu_to_le* conversion, their prototype need
> to be declared with __le* explicitly.
>
> Declare data structures to __le* explicitly to address the issue:
> - struct idt_eeprom_seq::memaddr
> - struct idt_csr_seq::csraddr
> - struct idt_csr_seq::data
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202401261250.b07Yt30Z-lkp@xxxxxxxxx/
> Signed-off-by: Dawei Li <dawei.li@xxxxxxxxxxxx>
> Reviewed-by: Serge Semin <fancer.lancer@xxxxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>