Re: [REGRESSION] `lis3lv02d_i2c_suspend()` causes `unbalanced disables for regulator-dummy` and `Failed to disable Vdd_IO: -EIO`

From: Linux regression tracking (Thorsten Leemhuis)
Date: Wed Feb 14 2024 - 10:35:09 EST


On 08.02.24 15:34, Mark Brown wrote:
> On Fri, Feb 02, 2024 at 12:38:04PM +0100, Paul Menzel wrote:
>
>> Testing commit 2f189493ae32 (i2c: i801: Add lis3lv02d for Dell XPS 15 7590)
>> [1], it’s very likely this commit, it turns out, that Linux logs the warning
>> below during ACPI S3 suspend:

Mark, many thx for your reply:

> The driver is just buggy here AFAICT,

/me reads that as "buggy even before 2f189493ae32, that commit just
exposed the problem"

> it's powering off the device in
> both runtime suspend and runtime resume so if the device is runtime
> suspended when system suspend happens then it'll power off the device
> again. The runtime suspend and system suspend need to talk to each
> other here.

Well, that was 6 days ago and nothing further happened. Makes me wonder:
Who will look into this? And when? If not any time soon I guess we
sooner or later should consider revert this. Yes, the problem is "just"
a warning, but well, it's not "just" a warning for people using
panic_on_warn...

Paul, just to be sure: I assume reverting 2f189493ae32 fixes the problem?

Ciao, Thorsten