Re: [PATCH 04/30] sched: make test_*_tsk_thread_flag() return bool

From: Ankur Arora
Date: Wed Feb 14 2024 - 21:05:01 EST



Mark Rutland <mark.rutland@xxxxxxx> writes:

> On Mon, Feb 12, 2024 at 09:55:28PM -0800, Ankur Arora wrote:
>> All users of test_*_tsk_thread_flag() treat the result as boolean.
>> This is also true for the underlying test_and_*_bit() operations.
>>
>> Change the return type to bool.
>>
>> Cc: Peter Ziljstra <peterz@xxxxxxxxxxxxx>
>> Originally-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Link: https://lore.kernel.org/lkml/87jzshhexi.ffs@tglx/
>> Signed-off-by: Ankur Arora <ankur.a.arora@xxxxxxxxxx>
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

Thanks.

> I think this makes sense on its own regardless of the rest of the series; it
> might make sense to move it to the start of the series so that it can easily be
> picked up even if the rest needs work.

Yeah that makes sense. Will do.

--
ankur