Re: [PATCH v12 04/25] genirq/irqdomain: Add DOMAIN_BUS_DEVICE_IMS

[Marc Zyngier]

On Sat, 27 Jan 2024 16:17:32 +0000,
Anup Patel <apatel@xxxxxxxxxxxxxxxx> wrote:
> 
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> 
> Add a new domain bus token to prepare for device MSI which aims to replace
> the existing platform MSI maze.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Anup Patel <apatel@xxxxxxxxxxxxxxxx>
> ---
>  include/linux/irqdomain_defs.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/irqdomain_defs.h b/include/linux/irqdomain_defs.h
> index c29921fd8cd1..4c69151cb9d2 100644
> --- a/include/linux/irqdomain_defs.h
> +++ b/include/linux/irqdomain_defs.h
> @@ -26,6 +26,7 @@ enum irq_domain_bus_token {
>  	DOMAIN_BUS_DMAR,
>  	DOMAIN_BUS_AMDVI,
>  	DOMAIN_BUS_PCI_DEVICE_IMS,
> +	DOMAIN_BUS_DEVICE_IMS,

Only a personal taste, but since we keep calling it "device MSI",
which it really is, I find it slightly odd to name the token
"DEVICE_IMS".

From what I understand, IMS is PCIe specific. Platform (and by
extension device) MSI extends far beyond PCIe. So here, DEVICE_MSI
would make a lot more sense and avoid confusion.

But hey, I don't have much skin in this game, and I can probably
mentally rotate the acronym...

	M.

-- 
Without deviation from the norm, progress is not possible.