Re: [PATCH v2 09/15] auxdisplay: linedisp: Add support for overriding character mapping

[Andy Shevchenko]

On Thu, Feb 15, 2024 at 11:36:47AM +0100, Geert Uytterhoeven wrote:
> On Mon, Feb 12, 2024 at 6:04 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

..

> > +static const struct attribute_group linedisp_group = {
> > +       .is_visible     = linedisp_attr_is_visible,
> 
> Shouldn't that be .is_bin_visible?
> 
> > +       .attrs          = linedisp_attrs,
> 
> Likewise, .bin_attrs?
> But that is a pre-existing issue in the ht16k33 driver.

I was wondering myself, but we have no infrastructure for that
(there are no DEVICE_BIN_ATTR_*() helpers, nor bin_attr member
 in struct device attribute).

As you pointed out, it's preexisted issue and should be addressed
separately and not only in this driver.

> > +};
> > +__ATTRIBUTE_GROUPS(linedisp);

-- 
With Best Regards,
Andy Shevchenko