Re: [RFC PATCH v2 4/6] dt-bindings: input: add entry for Marvell 88PM88X PMICs onkey

[Rob Herring]

On Sun, Feb 11, 2024 at 10:35:54AM +0100, Karel Balej wrote:
> From: Karel Balej <balejk@xxxxxxxxx>
> 
> Marvell 88PM88X PMICs provide onkey functionality -- add the bindings.
> 
> Signed-off-by: Karel Balej <balejk@xxxxxxxxx>
> ---
> 
> Notes:
>     RFC v2:
>     - Add wakeup-source property and reference onkey schema from MFD.
>     - Reword commit message.
> 
>  .../bindings/input/marvell,88pm88x-onkey.yaml | 32 +++++++++++++++++++
>  .../bindings/mfd/marvell,88pm88x.yaml         |  8 +++++
>  2 files changed, 40 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml
> new file mode 100644
> index 000000000000..5d3d451d0e1f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/marvell,88pm88x-onkey.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/marvell,88pm88x-onkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Onkey driver for Marvell 88PM88X PMICs.
> +
> +maintainers:
> +  - Karel Balej <balejk@xxxxxxxxx>
> +
> +description: |
> +  This module is part of the 88PM88X MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml.
> +
> +  The onkey controller is represented as a sub-node of the PMIC node in
> +  the device tree.

Why do you need a child node? You don't. Just add 'wakeup-source' to the 
parent.

> +
> +allOf:
> +  - $ref: input.yaml#

Doesn't look like you are using any properties from this?

> +
> +properties:
> +  compatible:
> +    const: marvell,88pm88x-onkey
> +
> +  wakeup-source: true
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +...