Re: [PATCH] gpio: cdev: avoid uninitialized variable dereference

[Bartosz Golaszewski]

On Fri, Feb 16, 2024 at 2:00 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The 'gc' variable is never set before it gets printed:
>
> drivers/gpio/gpiolib-cdev.c:2802:11: error: variable 'gc' is uninitialized when used here [-Werror,-Wuninitialized]
>  2802 |         chip_dbg(gc, "added GPIO chardev (%d:%d)\n", MAJOR(devt), gdev->id);
>       |                  ^~
> drivers/gpio/gpiolib.h:277:11: note: expanded from macro 'chip_dbg'
>   277 |         dev_dbg(&gc->gpiodev->dev, "(%s): " fmt, gc->label, ##__VA_ARGS__)
>       |                  ^~
>
> Use dev_dbg() directly.
>
> Fixes: 8574b5b47610 ("gpio: cdev: use correct pointer accessors with SRCU")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Hi Arnd,

I seem to have beat you to it[1] and my patch doesn't change the log
message so I'll apply it instead of this one.

Thanks,
Bartosz

[1] https://lore.kernel.org/linux-gpio/1542ef65-508b-45be-ad5c-63ad124cb1a2@xxxxxxxxxxx/T/#t