Re: [net-next RFC PATCH 6/6] net: phy: bcm7xxx: rework phy_driver table to new multiple PHY ID format

From: Florian Fainelli
Date: Sun Feb 18 2024 - 23:26:42 EST




On 2/18/2024 11:00 AM, Christian Marangi wrote:
Rework bcm7xxx PHY driver table to new multiple PHY format
implementation to reduce code duplication and final size of the compiled
module.

I like the idea of sharing as much code as possible and creating a smaller module, however by changing the name, you are creating an user-space ABI change, we rely upon the exact PHY name being shown under /sys/class/mdio_bus/*/* and this change will break that.

Thanks!
--
Florian