Re: [PATCH] mm: memcontrol: clarify swapaccount=0 deprecation warning

[Michal Koutný]

On Tue, Feb 13, 2024 at 03:16:34AM -0500, Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> The swapaccount deprecation warning is throwing false positives. Since
> we deprecated the knob and defaulted to enabling, the only reports
> we've been getting are from folks that set swapaccount=1. While this
> is a nice affirmation that always-enabling was the right choice, we
> certainly don't want to warn when users request the supported mode.

But shouldn't such users be still warned about effectively unused option?
I think `return 0;` from the param handler should ensure that.


> +	if (!kstrtobool(s, &res) && !res)
> +		pr_warn_once("The swapaccount=0 commdandline option is deprecated "
                                                commandline

Regards,
Michal

Attachment: signature.asc
Description: PGP signature