Re: [PATCH v5 09/12] cifs: Cut over to using netfslib

From: David Howells
Date: Mon Feb 19 2024 - 10:09:16 EST


Simon Horman <horms@xxxxxxxxxx> wrote:

> However, the code below this hunk, other than being guarded by
> smb3_use_rdma_offload(io_parms), uses rdata unconditionally.

Yeah - it does that even without my patches. SMB2_read() can call the
function with rdata == NULL, but I'm unsure as to whether the RDMA branch will
ever be used except for actual reads - in which case rdata will not be NULL at
the "rdata->mr" point.

David