Re: [PATCH 1/2] afs: Fix ignored callbacks over ipv4

[Matthew Wilcox]

On Mon, Feb 19, 2024 at 02:39:02PM +0000, David Howells wrote:
> +++ b/fs/afs/internal.h
> @@ -321,8 +321,7 @@ struct afs_net {
>  	struct list_head	fs_probe_slow;	/* List of afs_server to probe at 5m intervals */
>  	struct hlist_head	fs_proc;	/* procfs servers list */
>  
> -	struct hlist_head	fs_addresses4;	/* afs_server (by lowest IPv4 addr) */
> -	struct hlist_head	fs_addresses6;	/* afs_server (by lowest IPv6 addr) */
> +	struct hlist_head	fs_addresses;	/* afs_server (by lowest IPv6 addr) */

Comment is out of date ...

> @@ -561,8 +560,7 @@ struct afs_server {
>  	struct afs_server __rcu	*uuid_next;	/* Next server with same UUID */
>  	struct afs_server	*uuid_prev;	/* Previous server with same UUID */
>  	struct list_head	probe_link;	/* Link in net->fs_probe_list */
> -	struct hlist_node	addr4_link;	/* Link in net->fs_addresses4 */
> -	struct hlist_node	addr6_link;	/* Link in net->fs_addresses6 */
> +	struct hlist_node	addr_link;	/* Link in net->fs_addresses6 */

Ditto