Re: [PATCH 1/3] mei: vsc: Call wake_up() and event handler in a workqueue

[Sakari Ailus]

Hi Wentong,

On Sun, Feb 18, 2024 at 01:23:30AM +0000, Wu, Wentong wrote:
> Hi Sakari,
> 
> Thanks, and sorry for the late response because I'm in vacation this week.

No worries and thanks for the review.

> 
> > From: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > 
> > The event handler, in this case that of mei_vsc_event_cb() of platform-vsc.c,
> > is called from a threaded interrupt handler in uninterruptible context.
> 
> But why this thread is uninterruptible?
> 
> https://github.com/torvalds/linux/blob/master/kernel/irq/manage.c#L1294
> 
> https://lwn.net/Articles/302043/

I guess I sent this too hastily. You can indeed sleep there.

Moving wake_up() to the threaded handler should thus be enough. I'll send
v2.

-- 
Regards,

Sakari Ailus