Re: [PATCH v4 03/11] fs: Initial atomic write support

From: John Garry
Date: Tue Feb 20 2024 - 03:15:06 EST


On 19/02/2024 19:16, David Sterba wrote:
On Mon, Feb 19, 2024 at 01:01:01PM +0000, John Garry wrote:
From: Prasad Singamsetty<prasad.singamsetty@xxxxxxxxxx>
--- a/include/uapi/linux/fs.h
+++ b/include/uapi/linux/fs.h
@@ -301,9 +301,12 @@ typedef int __bitwise __kernel_rwf_t;
/* per-IO O_APPEND */
#define RWF_APPEND ((__force __kernel_rwf_t)0x00000010)
+/* Atomic Write */
+#define RWF_ATOMIC ((__force __kernel_rwf_t)0x00000040)
Should this be 0x20 so it's the next bit after RWF_APPEND?

Support for new flag RWF_NOAPPEND - which has value 0x20 - has been picked up on the vfs tree for 6.9 .

I had been just basing my series on Linus' release so far while also trying to anticipate any merge issue.

Thanks,
John