Re: [PATCH RFC v2 2/5] clk: hisilicon: add CRG driver for Hi3798MV200 SoC

[Yang Xiwen]

On 2/20/2024 6:11 PM, Krzysztof Kozlowski wrote:
> On 17/02/2024 13:52, Yang Xiwen via B4 Relay wrote:
> > +
> > +static const struct hisi_crg_funcs hi3798mv200_sysctrl_funcs = {
> > +	.register_clks = hi3798mv200_sysctrl_clk_register,
> > +	.unregister_clks = hi3798mv200_sysctrl_clk_unregister,
> > +};
> > +
> > +static const struct of_device_id hi3798mv200_crg_match_table[] = {
> > +	{ .compatible = "hisilicon,hi3798mv200-crg",
> > +		.data = &hi3798mv200_crg_funcs },
> > +	{ .compatible = "hisilicon,hi3798mv200-sysctrl",
> > +		.data = &hi3798mv200_sysctrl_funcs },
> These are undocumented compatibles. Run checkpatch or properly order
> your patchset.
It's in patch 5. You mean binding patch first and then driver?
> Best regards,
> Krzysztof

--
Regards,
Yang Xiwen