Re: [PATCH v13 07/13] irqchip/riscv-imsic: Add device MSI domain support for platform devices

[Thomas Gleixner]

On Tue, Feb 20 2024 at 22:22, Anup Patel wrote:
> On Tue, Feb 20, 2024 at 7:02 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>>
>> On Tue, Feb 20 2024 at 11:37, Anup Patel wrote:
>> > +#ifdef CONFIG_SMP
>> > +static void imsic_msi_update_msg(struct irq_data *d, struct imsic_vector *vec)
>> > +{
>> > +     struct msi_msg msg[2] = { [1] = { }, };
>>
>> That's a weird initializer and why do you need an array here?
>>
>>        struct msi_msg msg = { };
>>
>> Should be sufficient, no?
>
> I had taken reference from irq_msi_update_msg() in
> arch/x86/kernel/apic/msi.c

Which is equally bogus :)

The charm of copy and pasta...

Thanks,

        tglx