Re: [PATCH v8 2/5] perf: util: use capstone disasm engine to show assembly instructions

[Namhyung Kim]

Hi Adrian and Changbin,

On Sun, Feb 18, 2024 at 10:33 PM Adrian Hunter <adrian.hunter@intelcom> wrote:
>
> On 17/02/24 09:40, Changbin Du wrote:
> > Currently, the instructions of samples are shown as raw hex strings
> > which are hard to read. x86 has a special option '--xed' to disassemble
> > the hex string via intel XED tool.
> >
> > Here we use capstone as our disassembler engine to give more friendly
> > instructions. We select libcapstone because capstone can provide more
> > insn details. Perf will fallback to raw instructions if libcapstone is
> > not available.
> >
> > The advantages compared to XED tool:
> >  * Support arm, arm64, x86-32, x86_64 (more could be supported),
> >    xed only for x86_64.
> >  * Immediate address operands are shown as symbol+offs.
> >
> > Signed-off-by: Changbin Du <changbin.du@xxxxxxxxxx>
>
> This is the only patch of V8 that made it to my inbox, Namhyung
> also mentioned problems receiving V7, but the patches are on lore.
>
> For whole patch set:
>
> Reviewed-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

I found it in my spam box, maybe there was a change in the spam
filtering logic.

Thanks,
Namhyung