Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173

[Ceclan Dumitru]

On 2/20/24 22:54, David Lechner wrote:
> On Tue, Feb 20, 2024 at 3:43 AM Dumitru Ceclan <mitrutzceclan@xxxxxxxxx> wrote:

..

>> +  clocks:
>> +    maxItems: 1
>> +    description: |
> 
> Don't need `|` here.
> 
The description contains ": ". Without '|' yaml syntax considers the
whole string before ':' as another attribute

>> +      Optional external clock source. Can include one clock source: external
>> +      clock or external crystal.
>> +

..

>> +
>> +      diff-channels:
>> +        items:
>> +          minimum: 0
>> +          maximum: 31
>> +
> 
> Are we missing `bipolar: true` here? (since we have
> unevaluatedProperties: false)
> 

No, since we are referencing the adc schema "$ref: adc.yaml"
Which contains:
"""
  bipolar:

    $ref: /schemas/types.yaml#/definitions/flag

    description: If provided, the channel is to be used in bipolar mode.
"""


..

>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> Aren't the various power supplies supposed to be required?
> 
> - avdd-supply
> - avdd2-supply
> - iovdd-supply

>From my point of view, if someone uses a single supply (avdd == avdd2 ==
iovdd), and uses only the internal reference then the supplies should
not necessarily be required.