Re: [PATCH][next] bcachefs: remove redundant assignment to variable ret

From: Kent Overstreet
Date: Wed Feb 21 2024 - 19:05:39 EST


On Wed, Feb 21, 2024 at 11:52:03AM +0000, Colin Ian King wrote:
> Variable ret is being assigned a value that is never read, it is
> being re-assigned a couple of statements later on. The assignment
> is redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/bcachefs/super-io.c:806:2: warning: Value stored to 'ret' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

I'll take this, but - entirely too much of the traffic on this list is
getting taken up by static analyzer bullshit, we need to cut down on
this