Re: [PATCH v2 2/4] interconnect: qcom: sc7280: enable QoS configuration

[Odelu Kukatla]

On 2/5/2024 8:42 PM, Krzysztof Kozlowski wrote:
> On 05/02/2024 15:56, Odelu Kukatla wrote:
>> Enable QoS configuration for the master ports with predefined values
>> for priority and urgency.
>>
>> Signed-off-by: Odelu Kukatla <quic_okukatla@xxxxxxxxxxx>
>> ---
>>  drivers/interconnect/qcom/sc7280.c | 332 +++++++++++++++++++++++++++++
>>  1 file changed, 332 insertions(+)
>>
>> diff --git a/drivers/interconnect/qcom/sc7280.c b/drivers/interconnect/qcom/sc7280.c
>> index 7d33694368e8..438f927935e5 100644
>> --- a/drivers/interconnect/qcom/sc7280.c
>> +++ b/drivers/interconnect/qcom/sc7280.c
>> @@ -1,6 +1,7 @@
>>  // SPDX-License-Identifier: GPL-2.0
>>  /*
>>   * Copyright (c) 2021, The Linux Foundation. All rights reserved.
>> + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
>>   *
>>   */
>>  
>> @@ -16,29 +17,53 @@
>>  #include "icc-rpmh.h"
>>  #include "sc7280.h"
>>  
>> +static struct qcom_icc_qosbox qhm_qspi_qos = {
> 
> Why this cannot be const?
> 

I am addressing this in V3.

>> +	.num_ports = 1,
>> +	.port_offsets = { 0x7000 },
>> +	.prio = 2,
>> +	.urg_fwd = 0,
> 
> 
> Best regards,
> Krzysztof
> 

Thanks,
Odelu