Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

[Andy Shevchenko]

On Thu, Feb 22, 2024 at 01:05:16PM +0100, Herve Codina wrote:
> On Mon, 12 Feb 2024 14:22:56 +0200
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

..

> > > +#include <linux/dma-mapping.h>
> > > +#include <linux/hdlc.h>
> > > +#include <linux/module.h>  
> > 
> > > +#include <linux/of.h>
> > > +#include <linux/of_platform.h>  
> > 
> > I do not see how these are being used, am I right?
> > What's is missing OTOH is the mod_devicetable.h.
> 
> Agree for removing of.h and of_platform.h.
> 
> Why do I need mod_devicetable.h ?
> Isn't including module.h enough ?

In that header the definitions of many of ID table data structures are located.
You are using that in the code.

-- 
With Best Regards,
Andy Shevchenko