RE: [Intel-wired-lan] [net-next v4] intel: make module parameters readable in sys filesystem

From: Pucha, HimasekharX Reddy
Date: Thu Feb 22 2024 - 12:08:54 EST


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Jon Maxwell
> Sent: Friday, February 16, 2024 3:31 AM
> To: Brandeburg, Jesse <jesse.brandeburg@xxxxxxxxx>
> Cc: intel-wired-lan@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; edumazet@xxxxxxxxxx; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; netdev@xxxxxxxxxxxxxx; kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; jmaxwell37@xxxxxxxxx; davem@xxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [net-next v4] intel: make module parameters readable in sys filesystem
>
> Linux users sometimes need an easy way to check current values of module
> parameters. For example the module may be manually reloaded with different
> parameters. Make these visible and readable in the /sys filesystem to allow
> that. But don't make the "debug" module parameter visible as debugging is
> enabled via ethtool msglvl.
>
> Signed-off-by: Jon Maxwell <jmaxwell37@xxxxxxxxx>
> ---
> V2: Remove the "debug" module parameter as per Andrew Lunns suggestion.
> V3: Correctly format v2.
> V4: Add ethtool msglvl to message. Remove deprecated ixgbe max_vfs
> drivers/net/ethernet/intel/e100.c | 4 ++--
> drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@xxxxxxxxx> (A Contingent worker at Intel)