Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache_create

[Paul Moore]

On Wed, Feb 21, 2024 at 10:06 PM Kunwu Chan <chentao@xxxxxxxxxx> wrote:
> Thanks for your reply.
> On 2024/2/22 08:10, Paul Moore wrote:
> > On Thu, Feb 15, 2024 at 10:54 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> >> On Tue, Jan 30, 2024 at 4:40 AM Kunwu Chan <chentao@xxxxxxxxxx> wrote:
> >>>
> >>> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> >>> introduces a new macro.
> >>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> >>> to simplify the creation of SLAB caches.
> >>>
> >>> Signed-off-by: Kunwu Chan <chentao@xxxxxxxxxx>
> >>> ---
> >>>   kernel/cred.c | 4 ++--
> >>>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> This seems reasonable to me, unless I see any objections I can pull
> >> this via the LSM tree next week.
> >
> > Actually, never mind, the original posting has some non-ASCII junk in
> > the patch and I'm not able to import it cleanly.
> Thanks for reply.
>
> I checked the patch with the checkpatch.pl script and applied it to
> another machine to compile and found no issues.
> Seems ok to me, what should I do next to clean up that non-ASCII junk.
>
> And i use :perl -ne 'print if /[^[:ascii:]]/'
> 0001-cred-Use-KMEM_CACHE-instead-of-kmem_cache_create.patch seems ok too.

Look at the message when in the mailing list archive (link below) and
you'll notice the extra characters:
https://lore.kernel.org/all/20240130094037.76895-1-chentao@xxxxxxxxxx/raw

.. and then look at a correctly submitted patch:
https://lore.kernel.org/all/20240126104403.1040692-1-omosnace@xxxxxxxxxx/raw

-- 
paul-moore.com