Re: [PATCH v3 3/8] dt-bindings: clock: histb-clock: split into two header files

[Yang Xiwen]

On 2/23/2024 2:11 AM, Krzysztof Kozlowski wrote:
> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
> > From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> >
> > The CRG driver between different SoCs provides different clocks and
> > resets. We should not provide a generic header file across all HiSTB
> > SoCs, instead each CRG driver should provide its own.
> >
> > Split histb-clock.h into two files: hisilicon,hi3798cv200-crg.h and
> > hisilicon,hi3798cv200-sysctrl.h. This header file is for Hi3798CV200
> > only actually. For other HiSTB SoCs, some clock definitions are missing.
> >
> > Create a new histb-clock.h to include these two files for backward
> > compatibility only. Deprecate this file as well.
> >
> > Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> > ---
> >   .../dt-bindings/clock/hisilicon,hi3798cv200-crg.h  | 62 ++++++++++++++++++
> >   .../clock/hisilicon,hi3798cv200-sysctrl.h          | 17 +++++
> >   include/dt-bindings/clock/histb-clock.h            | 73 +++-------------------
> >   3 files changed, 87 insertions(+), 65 deletions(-)


Should I fix the #ifndef #define #endif stuffs here? i.e. s/DTS/DT_BINDING


> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof

--
Regards,
Yang Xiwen