Re: [PATCH 2/2] checkpatch: Don't check for unified diff format in git sendemail headers

[Joe Perches]

On Thu, 2024-02-22 at 17:10 -0800, Saravana Kannan wrote:
> On Thu, Feb 22, 2024 at 5:01 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > 
> > On Thu, 2024-02-22 at 16:45 -0800, Saravana Kannan wrote:
> > > On Thu, Feb 22, 2024 at 12:54 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > > > 
> > > > On Wed, 2024-02-21 at 21:15 -0800, Saravana Kannan wrote:
> > > > > When checkpatch is used as a git sendemail-validate hook, it's also passed
> > > > > in the email header for sanity check.
> > > > 
> > > > Why?
> > > > 
> > > > If so, why not use a front-end script to stop/remove
> > > > the file from being scanned by checkpatch?
> > > 
> > > Sure, I could do that. But this also makes it easier for people to
> > > start using checkpatch. Or I can put up a git hook wrapper script in
> > > here for people to symlink into their .git/hooks that does this.
> > > 
> > > I'd prefer the lazy route of not creating a 1 line wrapper script :)
> > 
> > I'd not.  checkpatch is for _patches_.
> > Don't feed stuff to it that isn't patches and expect good results.
> 
> Would you be open to being a maintainer if I add a git hook
> sendemail-validate wrapper? It feels silly to add myself as a
> maintainer for a 1-line script. I'd rather give it to you :)

<shrug>

I think you need a local script and not one in the tree.
Or maybe some different git invocation command.  Dunno.