Re: [PATCH vRFC 3/8] treewide: rename firmware_request_platform()
From: Greg KH
Date: Fri Feb 23 2024 - 01:21:40 EST
On Thu, Feb 22, 2024 at 11:30:28PM +0530, Mukesh Ojha wrote:
> Rename firmware_request_platform() to request_firmware_platform()
> to be more concrete and align with the name of other request
> firmware family functions.
Sorry, but no, it should be "noun_verb" for public functions.
Yes, we mess this up a lot, but keeping the namespace this way works out
better for global symbols, so "firmware_*" is best please.
thanks,
greg k-h