Re: [PATCH v2 4/4] dt-bindings: display: simple: hardware can use several properties

[Raphael Gallais-Pou]

On 2/23/24 01:09, Rob Herring wrote:
> On Sat, Feb 17, 2024 at 12:02:58PM +0100, Raphael Gallais-Pou wrote:
>> Setting a panel-timing in the device-tree overwrite the one specified in
>> the driver and set it as preferred.  In that case 'height-mm',
>> 'width-mm' and 'panel-timing' are properties that can be use for simple
>> panels, according to panel-common.yaml
>>
>> Fixes following warnings:
>> arch/arm/boot/dts/st/stm32mp135f-dk.dtb: panel-rgb: 'height-mm', 'panel-timing', 'width-mm' do not match any of the regexes: 'pinctrl-[0-9]+'
>> 	from schema $id: http://devicetree.org/schemas/display/panel/panel-simple.yaml#
>>
>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 634a10c6f2dd..c02cbbc7a100 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -352,6 +352,9 @@ properties:
>>    no-hpd: true
>>    hpd-gpios: true
>>    data-mapping: true
>> +  height-mm: true
>> +  width-mm: true
>> +  panel-timing: true
Hi Rob,
> Instead, just change 'additionalProperties' to 'unevaluateProperties' 
> and drop all these 'prop: true' lines. Pretty much anything from 
> panel-common.yaml should be allowed.


Will do, thanks :)


Best regards,

Raphaël

>
> Rob