Re: [PATCH v6 4/5] dt-bindings: iio: light: Avago APDS9306

From: Jonathan Cameron
Date: Sat Feb 24 2024 - 09:38:33 EST


On Sun, 18 Feb 2024 16:18:25 +1030
Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx> wrote:

> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.

I deleted this first line of the patch description. Doesn't seem related
to the binding doc change.

> Extend avago,apds9300.yaml schema file to support apds9306 device.
>
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Subhajit Ghosh <subhajit.ghosh@xxxxxxxxxxxxxx>
> ---
> v6 -> v7:
> - Removed wrong patch dependency statement
> - Added tag
> https://lore.kernel.org/all/5089c549-505f-4342-b3fe-bed8a29b6ce1@xxxxxxxxxx/
> https://lore.kernel.org/all/20240206-gambling-tricycle-510794e20ca8@spud/
>
> v5 -> v6:
> - Write proper commit messages
> - Add vdd-supply in a separate commit
> - Add Interrupt macro in a separate commit
> Link: https://lore.kernel.org/all/1d0a80a6-dba5-4db8-a7a8-73d4ffe7a37e@xxxxxxxxxx/
>
> v2 -> v5:
> - Removed 'required' for Interrupts and 'oneOf' for compatibility strings
> as per below reviews:
> Link: https://lore.kernel.org/lkml/20231028142944.7e210eb6@jic23-huawei/
> Link: https://lore.kernel.org/lkml/22e9e5e9-d26a-46e9-8986-5062bbfd72ec@xxxxxxxxxx/
> ---
> Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
> index e07a074f6acf..b750096530bc 100644
> --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml
> @@ -12,11 +12,13 @@ maintainers:
> description: |
> Datasheet: https://www.avagotech.com/docs/AV02-1077EN
> Datasheet: https://www.avagotech.com/docs/AV02-4191EN
> + Datasheet: https://www.avagotech.com/docs/AV02-4755EN
>
> properties:
> compatible:
> enum:
> - avago,apds9300
> + - avago,apds9306
> - avago,apds9960
>
> reg: