Re: [PATCH v3 10/15] clk: samsung: Keep register offsets in chip specific structure
From: Krzysztof Kozlowski
Date: Sun Feb 25 2024 - 11:01:36 EST
On 24/02/2024 21:20, Sam Protsenko wrote:
> Abstract CPU clock registers by keeping their offsets in a dedicated
> chip specific structure to accommodate for oncoming Exynos850 support,
> which has different offsets for cluster 0 and cluster 1. This rework
> also makes it possible to use exynos_set_safe_div() for all chips, so
> exynos5433_set_safe_div() is removed here to reduce the code
> duplication. The ".regs" field has to be (void *) as different Exynos
> chips can have very different register layout, so this way it's possible
> for ".regs" to point to different structures, each representing its own
> chip's layout.
>
> No functional change.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> ---
Missing checkpatch --strict:
ERROR: "foo * const bar" should be "foo * const bar"
Corrected and applied.
Best regards,
Krzysztof