Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage

From: Joseph Qi
Date: Sun Feb 25 2024 - 20:11:28 EST




On 2/25/24 9:02 PM, Chengming Zhou wrote:
> On 2024/2/25 20:20, Joseph Qi wrote:
>>
>>
>> On 2/24/24 9:50 PM, chengming.zhou@xxxxxxxxx wrote:
>>> From: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx>
>>>
>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>>> its usage so we can delete it from slab. No functional change.
>>>
>> If I understand correctly, you are referring the following patch:
>> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@xxxxxxx/
>>
>> But it seems that the above patch is not included in mainline yet.
>> Or am I missing something?
>
> I realize my commit message should explain more why it's a no-op, my bad.
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed so it became a dead flag as of v6.8-rc1. That series[1]
> mark it obsolete to avoid confusion for users. So here we can just
> remove all its users, which has no functional changes.
>
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@xxxxxxx/
>
Take more look at v6.8-rc1, I've found the following commit:
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So,
Acked-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>