Re: [PATCH 1/2] iio: adc: ti-ads1298: Fix error code in probe()

From: Dan Carpenter
Date: Mon Feb 26 2024 - 02:46:15 EST


On Sat, Feb 24, 2024 at 06:13:54PM +0000, Jonathan Cameron wrote:
> On Thu, 22 Feb 2024 08:10:25 +0100
> Mike Looijmans <mike.looijmans@xxxxxxxx> wrote:
>
> > Good catch on both patches.
> >
> > If so desired, you have my
> >
> > Acked-by: Mike Looijmans <mike.looijmans@xxxxxxxx>
>
> Dan, here is a classic example of why I think any series with more than
> 1 patch could benefit from a cover letter. It gives somewhere for
> reviewers to give tags for the lot in a fashion b4 can understand.
>
> Otherwise great find and applied to the togreg branch of iio.git
> with Mike's tag added to both of them! Hopefully the fixes tags will
> remain stable - whilst in theory that tree doesn't get rebased, in practice
> it might if I messed anything up enough :(

Sure. I can start writing cover letters.

regards,
dan carpenter