Re: [PATCH net-next v4 5/6] net: hisilicon: add support for hisi_femac core on Hi3798MV200
From: Krzysztof Kozlowski
Date: Mon Feb 26 2024 - 02:54:47 EST
On 22/02/2024 13:43, Yang Xiwen via B4 Relay wrote:
> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>
> Register the sub MDIO bus if it is found. Also implement the internal
> PHY reset procedure as needed.
>
> + ret = clk_bulk_prepare_enable(CLK_NUM, priv->clks);
> + if (ret) {
> + dev_err(&pdev->dev, "failed to enable clk bulk: %d\n", ret);
> + return ret;
> + }
>
> - clk_prepare_enable(priv->clk);
> if (priv->phy_rst)
> hisi_femac_phy_reset(priv);
>
> @@ -948,6 +993,7 @@ static const struct of_device_id hisi_femac_match[] = {
> {.compatible = "hisilicon,hisi-femac-v1",},
> {.compatible = "hisilicon,hisi-femac-v2",},
> {.compatible = "hisilicon,hi3516cv300-femac",},
> + {.compatible = "hisilicon,hi3798mv200-femac",},
What's the point of growing the list? All are fully compatible according
to your match table.
Stop growing it and either express compatibility or use proper match
data, if they are not compatible.
Best regards,
Krzysztof