Re: [syzbot] [ntfs3?] possible deadlock in ntfs_set_state (2)

From: Hillf Danton
Date: Mon Feb 26 2024 - 07:07:34 EST


Test non-zero subkey against the mainline tree.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

--- x/fs/ntfs3/fsntfs.c
+++ y/fs/ntfs3/fsntfs.c
@@ -944,7 +944,7 @@ int ntfs_set_state(struct ntfs_sb_info *
if (!ni)
return -EINVAL;

- mutex_lock_nested(&ni->ni_lock, NTFS_INODE_MUTEX_DIRTY);
+ mutex_lock_nested(&ni->ni_lock, (1 + NTFS_INODE_MUTEX_PARENT2));

attr = ni_find_attr(ni, NULL, NULL, ATTR_VOL_INFO, NULL, 0, NULL, &mi);
if (!attr) {
--