Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide suspend

From: Dhruva Gole
Date: Mon Feb 26 2024 - 07:18:20 EST


Hi Mark, Theo,

+ Nishanth, Vignesh (maintainers of TI K3)

On Feb 22, 2024 at 19:13:29 +0000, Mark Brown wrote:
> On Thu, 22 Feb 2024 11:12:28 +0100, Théo Lebrun wrote:
> > This fixes runtime PM and system-wide suspend for the cadence-qspi
> > driver. Seeing how runtime PM and autosuspend are enabled by default, I
> > believe this affects all users of the driver.
> >
> > This series has been tested on both Mobileye EyeQ5 hardware and the TI
> > J7200 EVM board, under s2idle.
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
>
> Thanks!
>
> [1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks
> commit: 32ce3bb57b6b402de2aec1012511e7ac4e7449dc
> [2/4] spi: cadence-qspi: remove system-wide suspend helper calls from runtime PM hooks
> commit: 959043afe53ae80633e810416cee6076da6e91c6
> [3/4] spi: cadence-qspi: put runtime in runtime PM hooks names
> commit: 4efa1250b59ebf47ce64a7b6b7c3e2e0a2a9d35a
> [4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks
> commit: 078d62de433b4f4556bb676e5dd670f0d4103376

It seems like between 6.8.0-rc5-next-20240220 and
6.8.0-rc5-next-20240222 some of TI K3 platform boot have been broken.

It particularly seemed related to these patches because we can see
cqspi_probe in the call trace and also cqspi_suspend toward the top.

See logs for kernel crash in [0] and working in [1]


[0] https://gist.github.com/DhruvaG2000/ed997452b41d6e5301598225fc579800
[1] https://gist.github.com/DhruvaG2000/d4e73111aeafaca555ba2d5208deb6dd

--
Best regards,
Dhruva Gole <d-gole@xxxxxx>