Re: [PATCH v4] clk: keystone: sci-clk: Adding support for non contiguous clocks

From: Kumar, Udit
Date: Mon Feb 26 2024 - 08:48:56 EST



On 2/26/2024 4:24 PM, Francesco Dolcini wrote:
On Tue, Feb 13, 2024 at 01:56:40PM +0530, Udit Kumar wrote:
Most of clocks and their parents are defined in contiguous range,
But in few cases, there is gap in clock numbers[0].
Driver assumes clocks to be in contiguous range, and add their clock
ids incrementally.

New firmware started returning error while calling get_freq and is_on
API for non-available clock ids.
Is this the kind of errors I should expect in such situation?

ti-sci-clk 44043000.system-controller:clock-controller: recalc-rate failed for dev=13, clk=7, ret=-19

If this is the case, I feel like this patch should be back-ported to
stable kernels.

Sure will send to stable@xxxxxxxxxxxxxxx


Any malfunction because of these errors or just some noise in the logs?

Error is noise in logs, no impact on function as these reserved clocks

are not used by drivers.



Francesco