Re: [PATCH v3] clkdev: Update clkdev id usage to allow for longer names

From: Andy Shevchenko
Date: Mon Feb 26 2024 - 10:18:56 EST


On Fri, Feb 23, 2024 at 03:25:56PM -0500, Michael J. Ruhl wrote:
> clkdev DEV ID information is limited to an array of 20 bytes
> (MAX_DEV_ID). It is possible that the ID could be longer than
> that. If so, the lookup will fail because the "real ID" will
> not match the copied value.
>
> For instance, generating a device name for the I2C Designware
> module using the PCI ID can result in a name of:
>
> i2c_designware.39424
>
> clkdev_create() will store:
>
> i2c_designware.3942
>
> The stored name is one off and will not match correctly during probe.
>
> Increase the size of the ID to allow for a longer name.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko