Re: [PATCH] platform/x86/amd/pmf: Fix missing error code in amd_pmf_init_smart_pc()

[Mario Limonciello]

On 2/26/2024 08:53, Ilpo Järvinen wrote:
> On Mon, 26 Feb 2024, Harshit Mogalapalli wrote:
>
> > On the error path, assign -ENOMEM to ret when memory allocation of
> > "dev->prev_data" fails.
> >
> > Fixes: e70961505808 ("platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc()")
> > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> > ---
> > This is based on static analysis with smatch, only compile tested
> > ---
> >   drivers/platform/x86/amd/pmf/tee-if.c | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
> > index 8527dca9cf56..dcbe8f85e122 100644
> > --- a/drivers/platform/x86/amd/pmf/tee-if.c
> > +++ b/drivers/platform/x86/amd/pmf/tee-if.c
> > @@ -458,8 +458,10 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev)
> >   	amd_pmf_hex_dump_pb(dev);
> >   
> >   	dev->prev_data = kzalloc(sizeof(*dev->prev_data), GFP_KERNEL);
> > -	if (!dev->prev_data)
> > +	if (!dev->prev_data) {
> > +		ret = -ENOMEM;
> >   		goto error;
> > +	}
> >   
> >   	ret = amd_pmf_start_policy_engine(dev);
> >   	if (ret)
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Thanks for the patch!

Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>