Re: [PATCH v2] tracing: Add warning if string in __assign_str() does not match __string()

From: Steven Rostedt
Date: Mon Feb 26 2024 - 12:07:28 EST


On Mon, 26 Feb 2024 09:33:28 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> On Fri, 23 Feb 2024 16:13:56 -0500
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > From: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx>
> >
> > In preparation to remove the second parameter of __assign_str(), make sure
> > it is really a duplicate of __string() by adding a WARN_ON_ONCE().
> >
>
> Looks good to me. So eventually this is removed when the second parameter
> is removed?

Yes, I applied this after my other patches.


>
> Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>


Thanks!

-- Steve