Re: [PATCHSET v2 wq/6.10] workqueue: Implement disable/enable_work()

[Tejun Heo]

Hello,

On Sun, Feb 25, 2024 at 06:55:56PM +0800, Lai Jiangshan wrote:
> > While I agree that this can be argued either way, keeping the interface
> > congruent with the existing cancel_work_sync() and friends seems a lot more
> > important to me. It can be a bit more confusing for users who are used to
> > tasklet interface but then again we aren't gonna rename cancel_work_sync()
> > to kill_work() and the conversion overhead isn't all that significant or
> > lasting. However, if we break the consnistency within workqueue API, that's
> > a source of lasting confusion.
> 
> I don't want to object to any names. But I'm still thinking of just providing
> disable_work_nosync() rather than disable work().  It will be used
> at only places at most.

Yeah, I get your point. That's the same for cancel_work_sync(). I'll think
about it some more but I'm not sure either way is clearly better here.

Thanks.

-- 
tejun