Re: [PATCH v18 029/121] KVM: TDX: create/free TDX vcpu structure

[Isaku Yamahata]

On Thu, Jan 25, 2024 at 11:06:22AM +0800,
Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx> wrote:

> > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
> > index 1c6541789c39..8330f448ab8e 100644
> > --- a/arch/x86/kvm/vmx/tdx.c
> > +++ b/arch/x86/kvm/vmx/tdx.c
> > @@ -411,6 +411,55 @@ int tdx_vm_init(struct kvm *kvm)
> >   	return 0;
> >   }
> > +int tdx_vcpu_create(struct kvm_vcpu *vcpu)
> > +{
> > +	struct kvm_tdx *kvm_tdx = to_kvm_tdx(vcpu->kvm);
> > +
> > +	/*
> > +	 * On cpu creation, cpuid entry is blank.  Forcibly enable
> > +	 * X2APIC feature to allow X2APIC.
> 
> This comment is a bit confusing.
> Do you mean force x2apic here or elsewhere?
> So far, in this patch, x2apic is not forced yet.
> 
> > +	 * Because vcpu_reset() can't return error, allocation is done here.
> 
> What do you mean "allocation" here?

Now this comment is stale, I removed it as Yuan pointed out.
-- 
Isaku Yamahata <isaku.yamahata@xxxxxxxxxxxxxxx>