Re: [PATCH v3] virt: tdx-guest: Handle GetQuote request error code

[Kuppuswamy Sathyanarayanan]

On 2/26/24 5:36 PM, Dan Williams wrote:
> Kuppuswamy Sathyanarayanan wrote:
>> The tdx-guest driver marshals quote requests via hypercall to have a
>> quoting enclave sign attestation evidence about the current state of
>> the TD. There are 2 possible failures, a transport failure (failure
>> to communicate with the quoting agent) and payload failure (a failed
>> quote). The driver only checks the former, update it to consider the
>> latter payload errors as well.
>>
>> Fixes: f4738f56d1dc ("virt: tdx-guest: Add Quote generation support using TSM_REPORTS")
>> Reported-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
>> Closes: https://lore.kernel.org/linux-coco/6bdf569c-684a-4459-af7c-4430691804eb@xxxxxxxxxxxxxxx/T/#u
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx>
>> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
>> Reviewed-by: Xiaoyao Li <xiaoyao.li@xxxxxxxxx>
>> Acked-by: Kai Huang <kai.huang@xxxxxxxxx>
> Looks good to me:
>
> Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
>
> ...if you decide you need a debug print here, or to differentiate the
> error codes based on transport vs payload error that can be a follow-on
> change.
Yes, will do. I will submit a pr_err() cleanup patch soon.

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer