Re: [PATCH net-next v5 12/16] net: dsa: vsc73xx: introduce tag 8021q for vsc73xx

[Jakub Kicinski]

On Fri, 23 Feb 2024 22:00:42 +0100 Pawel Dembicki wrote:
> This commit introduces a new tagger based on 802.1q tagging.
> It's designed for the vsc73xx driver. The VSC73xx family doesn't have
> any tag support for the RGMII port, but it could be based on VLANs.
> 
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>
> ---
> v5:
>   - removed skb_vlan_tag_present(skb) checking
>   - use 80 characters per line limit
> v4:
>   - rebase to net-next/main
> v3:
>   - Introduce a patch after the tagging patch split
> 
>  include/net/dsa.h           |  2 ++
>  net/dsa/Kconfig             |  6 ++++
>  net/dsa/Makefile            |  1 +
>  net/dsa/tag_vsc73xx_8021q.c | 66 +++++++++++++++++++++++++++++++++++++
>  4 files changed, 75 insertions(+)
>  create mode 100644 net/dsa/tag_vsc73xx_8021q.c

> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_VSC73XX_8021Q, VSC73XX_8021Q_NAME);
> +
> +module_dsa_tag_driver(vsc73xx_8021q_netdev_ops);

W=1 build generates:

WARNING: modpost: missing MODULE_DESCRIPTION() in net/dsa/tag_vsc73xx_8021q.o
-- 
pw-bot: cr