Re: [PATCH] powerpc/mm: Code cleanup for __hash_page_thp

[Kunwu Chan]

Thanks for the reply.
On 2024/2/27 14:07, Michael Ellerman wrote:
> Kunwu Chan <chentao@xxxxxxxxxx> writes:
> > Thanks for the reply.
> >
> > On 2024/2/26 18:49, Michael Ellerman wrote:
> > > Kunwu Chan <chentao@xxxxxxxxxx> writes:
> > > > This part was commented from commit 6d492ecc6489
> > > > ("powerpc/THP: Add code to handle HPTE faults for hugepages")
> > > > in about 11 years before.
> > > >
> > > > If there are no plans to enable this part code in the future,
> > > > we can remove this dead code.
> > >
> > > I agree the code can go. But I'd like it to be replaced with a comment
> > > explaining what the dead code was trying to say.
>
> > Thanks, i'll update a new patch with the following comment:
> >       /*
> >       * No CPU has hugepages but lacks no execute, so we
> >       * don't need to worry about cpu no CPU_FTR_COHERENT_ICACHE feature case
> >       */
>
> Maybe wait until we can get some input from Aneesh. I'm not sure the
> code/comment are really up to date.
I won't do anything until I get a reply.
I'll wait for the latest msg.

> cheers
--
Thanks,
  Kunwu