Re: [PATCH v2 1/4] rust: uaccess: add userspace pointers

From: Carlos López
Date: Tue Feb 27 2024 - 05:05:40 EST



On 8/2/24 16:47, Alice Ryhl wrote:
+ /// Create a reader that can access the same range of data.
+ ///
+ /// Reading from the clone does not advance the current reader.
+ ///
+ /// The caller should take care to not introduce TOCTOU issues, as described
+ /// in the documentation for [`UserSlice`].
+ pub fn clone_reader(&self) -> UserSliceReader {
+ UserSliceReader {
+ ptr: self.ptr,
+ length: self.length,
+ }
+ }

Just out of curiosity, is there any reason why this is not implemented
in terms of the Clone trait?

--
Carlos López
Security Engineer
SUSE Software Solutions