Re: [PATCH v4] platform/x86/fujitsu-laptop: Add battery charge control support

From: Ilpo Järvinen
Date: Tue Feb 27 2024 - 05:18:29 EST


On Mon, 19 Feb 2024, Ilpo Järvinen wrote:

> On Thu, 15 Feb 2024 20:31:43 +0000, Szilard Fabian wrote:
>
> > This patch adds battery charge control support on Fujitsu notebooks
> > via the S006 method of the FUJ02E3 ACPI device. With this method it's
> > possible to set charge_control_end_threshold between 50 and 100%.
> >
> > Tested on Lifebook E5411 and Lifebook U728. Sadly I can't test this
> > patch on a dual battery one, but I didn't find any clue about
> > independent battery charge control on dual battery Fujitsu notebooks
> > either. And by that I mean checking the DSDT table of various Lifebook
> > notebooks and reverse engineering FUJ02E3.dll.
> >
> > [...]
>
>
> Thank you for your contribution, it has been applied to my local
> review-ilpo branch. Note it will show up in the public
> platform-drivers-x86/review-ilpo branch only once I've pushed my
> local branch there, which might take a while.
>
> The list of commits applied:
> [1/1] platform/x86/fujitsu-laptop: Add battery charge control support
> commit: 9b716ef48c90446b8d6d86726c6c3f0141e53091

Hi,

Can you please take a look at the two build failures LKP has brought up.
They looked like some depends on and/or select clauses missing from
Kconfig.

I'll be merging the patches that fix those into the original commit so
don't spend too much fine-tuning the commit message.

--
i.