Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing

From: Fabio Estevam
Date: Tue Feb 27 2024 - 06:22:44 EST


Hi Steffen,

On Mon, Feb 26, 2024 at 6:15 AM Steffen Bätz <steffen@xxxxxxxxxxxx> wrote:
>
> As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to
> be filled")
> Marvell 88e6320/21 switches fail to be probed:
>
> ...
> mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfaces
> error creating PHYLINK: -22
> ...
>
> The problem stems from the use of mv88e6185_phylink_get_caps() to get
> the device capabilities. Create a new dedicated phylink_get_caps for the
> 6320 and 6321 to properly support their set of capabilities.
>
> Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled")
> Signed-off-by: Steffen Bätz <steffen@xxxxxxxxxxxx>

Thanks for the fix.

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>