Re: [PATCH 3/4] arch: define CONFIG_PAGE_SIZE_*KB on all architectures

From: Heiko Carstens
Date: Tue Feb 27 2024 - 08:58:08 EST


On Mon, Feb 26, 2024 at 05:14:13PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Most architectures only support a single hardcoded page size. In order
> to ensure that each one of these sets the corresponding Kconfig symbols,
> change over the PAGE_SHIFT definition to the common one and allow
> only the hardware page size to be selected.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
..
> arch/s390/Kconfig | 1 +
> arch/s390/include/asm/page.h | 2 +-
..
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index fe565f3a3a91..b61c74c10050 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -199,6 +199,7 @@ config S390
> select HAVE_MOD_ARCH_SPECIFIC
> select HAVE_NMI
> select HAVE_NOP_MCOUNT
> + select HAVE_PAGE_SIZE_4KB
> select HAVE_PCI
> select HAVE_PERF_EVENTS
> select HAVE_PERF_REGS
> diff --git a/arch/s390/include/asm/page.h b/arch/s390/include/asm/page.h
> index 73b9c3bf377f..ded9548d11d9 100644
> --- a/arch/s390/include/asm/page.h
> +++ b/arch/s390/include/asm/page.h
> @@ -11,7 +11,7 @@
> #include <linux/const.h>
> #include <asm/types.h>
>
> -#define _PAGE_SHIFT 12
> +#define _PAGE_SHIFT CONFIG_PAGE_SHIFT

Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>