Re: [RESEND PATCH] selftests/overlayfs: fix compilation error in overlayfs

From: Shuah Khan
Date: Tue Feb 27 2024 - 11:49:23 EST


On 2/27/24 00:42, Meng Li wrote:
make -C tools/testing/selftests, compiling dev_in_maps fail.
In file included from dev_in_maps.c:10:
/usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant
35 | MS_RDONLY = 1, /* Mount read-only. */
| ^~~~~~~~~

That sys/mount.h has to be included before linux/mount.h.

Signed-off-by: Meng Li <li.meng@xxxxxxx>
---
tools/testing/selftests/filesystems/overlayfs/dev_in_maps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


I don't see this problem when I build it on my system when
I run:

make -C tools/testing/selftests
or
make -C tools/testing/selftests/filesystems/overlayfs

Are you running this after doing headers_install?

thanks,
-- Shuah